Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Maxwell external circuit example #189

Merged
merged 21 commits into from
Aug 31, 2024
Merged

Conversation

IreneWoyna
Copy link
Contributor

Pull Request Template

Description

Please provide a brief description of the changes in this pull request.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

@IreneWoyna IreneWoyna changed the title Maxwell external circuit example FEAT: Maxwell external circuit example Aug 6, 2024
@IreneWoyna
Copy link
Contributor Author

@gmalinve please ignore this draft for now, it's only a placeholder, I will work on this later this week (and most likely change it completely)

@gmalinve
Copy link
Collaborator

gmalinve commented Aug 6, 2024 via email

@IreneWoyna IreneWoyna self-assigned this Aug 9, 2024
@IreneWoyna
Copy link
Contributor Author

@gmalinve @anur7 I've improved the example (or actually created a new one using the same file), I will work on it when I'm back from leave on 19.8. But this should be nearly final now, so you can take a look if you have time.

@gmalinve
Copy link
Collaborator

@IreneWoyna without the .sph file we can't test this :)

@IreneWoyna
Copy link
Contributor Author

@IreneWoyna without the .sph file we can't test this :)

circuit.export_netlist_from_schematic(netlist_file) creates the .sph file which is the imported into Maxwell design by maxwell.edit_external_circuit(netlist_file_path=netlist_file, schematic_design_name="test_circuit"). The .sph file can't exist before the circuit is created.

@gmalinve
Copy link
Collaborator

@IreneWoyna oh my bad :)

@IreneWoyna
Copy link
Contributor Author

@gmalinve and @anur7 any ideas why this doesn't work? the plot is empty

## Create rectangular plot

Plot winding currents

maxwell.post.create_report(
expressions=["Current(winding1)", "Current(winding2)", "Current(winding3)"],
domain="Time",
primary_sweep_variable="Time",
plot_name="Winding Currents",
)

@IreneWoyna IreneWoyna marked this pull request as ready for review August 21, 2024 07:56
@IreneWoyna
Copy link
Contributor Author

@gmalinve @anur7 this should be ready now, thanks for your patience and help!

@gmalinve gmalinve marked this pull request as draft August 21, 2024 08:03
@gmalinve
Copy link
Collaborator

Hey @IreneWoyna, thanks for your changes. There are still many things to fix though. There are comments that have been resolved but that haven't been tackled. Like the imports, the constants, the winding objects etc. If you need help we can talk :)

Copy link
Contributor Author

@IreneWoyna IreneWoyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gmalinve gmalinve self-assigned this Aug 28, 2024
@gmalinve gmalinve requested review from gmalinve and anur7 August 29, 2024 13:57
@gmalinve gmalinve marked this pull request as ready for review August 29, 2024 13:57
Copy link
Collaborator

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 8df5c76 into main Aug 31, 2024
11 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the add/circuit_maxwell branch August 31, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants